Repository navigation
fix(0.83, macos): Fabric accessibility roles and state, and TextInput read-only and Tab-stop fixes - #3190
Open
Jason Morse (JasonVMo) wants to merge 1 commit into
Open
fix(0.83, macos): Fabric accessibility roles and state, and TextInput read-only and Tab-stop fixes#3190Jason Morse (JasonVMo) wants to merge 1 commit into
Jason Morse (JasonVMo) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Backports #3136 to
0.83-stable, including the final review fixes. This restores macOS Fabric accessibility roles and states, separates read-only TextInput from disabled TextInput, and makes each Fabric TextInput a single Tab stop.The landed product and RNTester changes apply without conflicts. Includes a patch changeset for
react-native-macos.Test Plan:
git diff --check origin/0.83-stable...HEAD— passed.yarn install --immutable— passed with peer-dependency warnings.GITHUB_BASE_REF=0.83-stable yarn change:check— passed.yarn exec prettier --check packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js— passed.yarn exec eslint --max-warnings 0 packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js— passed.yarn flow-check --max-workers 4— passed (0 errors).RCT_NEW_ARCH_ENABLED=1 RCT_USE_PREBUILT_RNCORE=0 RCT_USE_RN_DEP=0 pod install(frompackages/rn-tester) — passed with CocoaPods 1.17.0.xcodebuild -workspace packages/rn-tester/RNTesterPods.xcworkspace -sdk macosx -configuration Debug -scheme RNTester-macOS -derivedDataPath packages/rn-tester/build -jobs 6 -quiet CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO build— passed.Not run locally: iOS or visionOS builds, the RNTester runtime accessibility and Tab-order scenarios, VoiceOver, or downstream FluentUI smoke tests. Paper is not supported on 0.83.